fix(regression): reverts grafana/loki#13039 to prevent use-after-free corruptions #13162
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
)" This reverts commit fc26431.
slim-bean
approved these changes
Jun 6, 2024
I don't think that is the case. When obtaining a |
chaudum
added a commit
that referenced
this pull request
Jun 7, 2024
…ruptions (#13162)" This reverts commit 41c5ee2. Signed-off-by: Christian Haudum <[email protected]>
chaudum
added a commit
that referenced
this pull request
Jun 7, 2024
--- Revert "fix(regression): reverts #13039 to prevent use-after-free corruptions (#13162)" This reverts commit 41c5ee2. Signed-off-by: Christian Haudum <[email protected]>
chaudum
added a commit
that referenced
this pull request
Jun 7, 2024
--- Revert "fix(regression): reverts #13039 to prevent use-after-free corruptions (#13162)" This reverts commit 41c5ee2. Signed-off-by: Christian Haudum <[email protected]>
7 tasks
chaudum
added a commit
that referenced
this pull request
Jun 7, 2024
--- Revert "fix(regression): reverts #13039 to prevent use-after-free corruptions (#13162)" This reverts commit 41c5ee2. Signed-off-by: Christian Haudum <[email protected]>
chaudum
added a commit
that referenced
this pull request
Jun 10, 2024
--- Revert "fix(regression): reverts #13039 to prevent use-after-free corruptions (#13162)" This reverts commit 41c5ee2. Signed-off-by: Christian Haudum <[email protected]>
chaudum
added a commit
that referenced
this pull request
Jun 19, 2024
--- Revert "fix(regression): reverts #13039 to prevent use-after-free corruptions (#13162)" This reverts commit 41c5ee2. Signed-off-by: Christian Haudum <[email protected]>
chaudum
added a commit
that referenced
this pull request
Jun 20, 2024
This PR re-introduces the fixed size memory pool that was originally introduced with #13039 but reverted with #13162 Additionally, it removes the package-global variable to store the type of allocator that should be used. Instead, the allocator type is passed during the bloom store creation. Signed-off-by: Christian Haudum <[email protected]>
This was referenced Jul 3, 2024
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Temporarily reverts #13039
Looks like that PR breaks the conventions around pool reuse (to safeguard use-after-free memory corruptions) described here and here.